Indefero Commit Details

Date:

2009-06-24 12:33:16 (15 years 5 months ago)

Author:

Loic d'Anterroches

Branch:

develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

fcefbe719fba52a19dad76e772a6138efc43ed8c

Parents:

7d3f7e226c44771e10b9ee2acb2a7b0763385c66

Message:

Fixed to better detect a bad commit.

Changes:

File differences

-134
135 135
136 136
137 
137
138
139
138 140
139 141
140 142
... ...
321 323
322 324
323 325
324 
326
325 327
326 328
327 329
+    {␊
        $folder = ($folder == '/') ? '' : $folder;␊
        // now we grab the info about this commit including its tree.␊
        $co = $this->getCommit($commit);␊
        if (false == ($co = $this->getCommit($commit))) {␊
            return false;␊
        }␊
        if ($folder) {␊
            // As we are limiting to a given folder, we need to find␊
            // the tree corresponding to this folder.␊

        }␊
        $out = array();␊
        exec($cmd, $out, $ret);␊
        if ($ret != 0) {␊
        if ($ret != 0 or count($out) == 0) {␊
            return false;␊
        }␊
        $log = array();␊
 ...
     {␊
         $folder = ($folder == '/') ? '' : $folder;␊
         // now we grab the info about this commit including its tree.␊
-        $co = $this->getCommit($commit);␊
+        if (false == ($co = $this->getCommit($commit))) {␊
+            return false;␊
+        }␊
         if ($folder) {␊
             // As we are limiting to a given folder, we need to find␊
             // the tree corresponding to this folder.␊
         }␊
         $out = array();␊
         exec($cmd, $out, $ret);␊
-        if ($ret != 0) {␊
+        if ($ret != 0 or count($out) == 0) {␊
             return false;␊
         }␊
         $log = array();␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags