Indefero Commit Details

Date:

2009-10-06 14:33:58 (15 years 6 months ago)

Author:

Loic d'Anterroches

Branch:

develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

ec8ff4f76b2036e657c71f338f872cb8b9120f85

Parents:

06668db697827803a378ea2333bcb7789e3fad02

Message:

Avoid unnecessary assignement.

Changes:

File differences

-240
241 241
242 242
243 
244 
243
245 244
246 245
247 246
... ...
281 280
282 281
283 282
284 
285 
283
286 284
287 285
288 286
+        $dep = Pluf_Model_InArray($dtag, $tags);␊
        $title = $page->title;␊
        $revision = $page->get_current_revision();␊
        $db = $page->getDbConnection();␊
        $false = Pluf_DB_BooleanToDb(false, $db);␊
        $false = Pluf_DB_BooleanToDb(false, $page->getDbConnection());␊
        $revs = $page->get_revisions_list(array('order' => 'creation_dtime DESC',␊
                                                'filter' => 'is_head='.$false));␊
        return Pluf_Shortcuts_RenderToResponse('idf/wiki/view.html',␊

␊
        $title = sprintf(__('Delete Old Revision of %s'), $page->title);␊
        $revision = $page->get_current_revision();␊
        $db = $page->getDbConnection();␊
        $false = Pluf_DB_BooleanToDb(false, $db);␊
        $false = Pluf_DB_BooleanToDb(false, $page->getDbConnection());␊
        $revs = $page->get_revisions_list(array('order' => 'creation_dtime DESC',␊
                                                'filter' => 'is_head='.$false));␊
        return Pluf_Shortcuts_RenderToResponse('idf/wiki/delete.html',␊
 ...
         $dep = Pluf_Model_InArray($dtag, $tags);␊
         $title = $page->title;␊
         $revision = $page->get_current_revision();␊
-        $db = $page->getDbConnection();␊
-        $false = Pluf_DB_BooleanToDb(false, $db);␊
+        $false = Pluf_DB_BooleanToDb(false, $page->getDbConnection());␊
         $revs = $page->get_revisions_list(array('order' => 'creation_dtime DESC',␊
                                                 'filter' => 'is_head='.$false));␊
         return Pluf_Shortcuts_RenderToResponse('idf/wiki/view.html',␊
 ␊
         $title = sprintf(__('Delete Old Revision of %s'), $page->title);␊
         $revision = $page->get_current_revision();␊
-        $db = $page->getDbConnection();␊
-        $false = Pluf_DB_BooleanToDb(false, $db);␊
+        $false = Pluf_DB_BooleanToDb(false, $page->getDbConnection());␊
         $revs = $page->get_revisions_list(array('order' => 'creation_dtime DESC',␊
                                                 'filter' => 'is_head='.$false));␊
         return Pluf_Shortcuts_RenderToResponse('idf/wiki/delete.html',␊

-146
147 147
148 148
149 
150 
149
151 150
152 151
153 152
+␊
    function get_current_revision() ␊
    {␊
        $db = $this->getDbConnection();␊
        $true = Pluf_DB_BooleanToDb(true, $db);␊
        $true = Pluf_DB_BooleanToDb(true, $this->getDbConnection());␊
        $rev = $this->get_revisions_list(array('filter' => 'is_head='.$true,␊
                                               'nb' => 1));␊
        return ($rev->count() == 1) ? $rev[0] : null;␊
 ␊
     function get_current_revision() ␊
     {␊
-        $db = $this->getDbConnection();␊
-        $true = Pluf_DB_BooleanToDb(true, $db);␊
+        $true = Pluf_DB_BooleanToDb(true, $this->getDbConnection());␊
         $rev = $this->get_revisions_list(array('filter' => 'is_head='.$true,␊
                                                'nb' => 1));␊
         return ($rev->count() == 1) ? $rev[0] : null;␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags