Indefero Commit Details

Date:

2009-07-12 15:13:52 (15 years 9 months ago)

Author:

Loic d'Anterroches

Branch:

develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

dc6f25cdef4e7a307b430739047807deb0ae2602

Parents:

36c1f98438d98b367a1da1f384853a420925ce24

Message:

Fixed to handle the case of bad commit.

Changes:

File differences

-271
272 272
273 273
274 
275 
276 274
277 275
276
277
278
279
280
281
282
283
284
278 285
279 286
280 287
+                                                  $scm->getMainBranch()));␊
            return new Pluf_HTTP_Response_Redirect($url);␊
        }␊
        $title = sprintf(__('%s Commit Details'), (string) $request->project);␊
        $page_title = sprintf(__('%s Commit Details - %s'), (string) $request->project, $commit);␊
        $large = $scm->isCommitLarge($commit);␊
        $cobject = $scm->getCommit($commit, !$large);␊
        if (!$cobject) {␊
            // Redirect to the first branch␊
            $url = Pluf_HTTP_URL_urlForView('IDF_Views_Source::treeBase',␊
                                            array($request->project->shortname,␊
                                                  $scm->getMainBranch()));␊
            return new Pluf_HTTP_Response_Redirect($url);␊
        }␊
        $title = sprintf(__('%s Commit Details'), (string) $request->project);␊
        $page_title = sprintf(__('%s Commit Details - %s'), (string) $request->project, $commit);␊
        $rcommit = IDF_Commit::getOrAdd($cobject, $request->project);␊
        $diff = new IDF_Diff($cobject->changes);␊
        $diff->parse();␊
                                                   $scm->getMainBranch()));␊
             return new Pluf_HTTP_Response_Redirect($url);␊
         }␊
-        $title = sprintf(__('%s Commit Details'), (string) $request->project);␊
-        $page_title = sprintf(__('%s Commit Details - %s'), (string) $request->project, $commit);␊
         $large = $scm->isCommitLarge($commit);␊
         $cobject = $scm->getCommit($commit, !$large);␊
+        if (!$cobject) {␊
+            // Redirect to the first branch␊
+            $url = Pluf_HTTP_URL_urlForView('IDF_Views_Source::treeBase',␊
+                                            array($request->project->shortname,␊
+                                                  $scm->getMainBranch()));␊
+            return new Pluf_HTTP_Response_Redirect($url);␊
+        }␊
+        $title = sprintf(__('%s Commit Details'), (string) $request->project);␊
+        $page_title = sprintf(__('%s Commit Details - %s'), (string) $request->project, $commit);␊
         $rcommit = IDF_Commit::getOrAdd($cobject, $request->project);␊
         $diff = new IDF_Diff($cobject->changes);␊
         $diff->parse();␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags