Indefero Commit Details

Date:

2012-06-05 13:55:21 (13 years 4 months ago)

Author:

Thomas Keller

Branch:

develop, release-1.3

Commit:

d17098e7037e448f01a35b99619d4959ac657558

Parents:

64c66747626f8ea7fd3afbb5e33e623e2bde3f1e

Message:

Ensure that PHP doesn't interpret read ini file values and therefor scrambles the output of hgrc files (issue 523).

Changes:

File differences

-5
6 6
7 7
8
9
10
11
8 12
9 13
10 14
+␊
## Bugfixes␊
␊
- A long standing bug in the Mercurial plugin that lead to corruption␊
  of boolean configuration values in the `hgrc` of the served repository␊
  has been fixed (issue 523).␊
 ␊
- If an anonymous or authenticated user had no access to any project in a ␊
  forge, all projects were listed for him (but still no one was actually␊
  accessible). This has been fixed. ␊
 ␊
 ## Bugfixes␊
 ␊
+- A long standing bug in the Mercurial plugin that lead to corruption␊
+  of boolean configuration values in the `hgrc` of the served repository␊
+  has been fixed (issue 523).␊
+ ␊
 - If an anonymous or authenticated user had no access to any project in a ␊
   forge, all projects were listed for him (but still no one was actually␊
   accessible). This has been fixed. ␊

-178
179 179
180 180
181 
181
182
183
184
182 185
183 186
184 187
+␊
        // Generate hgrc content ␊
        if (is_file($hgrc_file)) {␊
            $tmp_content = parse_ini_file($hgrc_file, true);␊
            $tmp_content = @parse_ini_file($hgrc_file, true, INI_SCANNER_RAW);␊
            if ($tmp_content === false) {␊
              throw new Exception('could not parse "'.$hgrc_file.'" because of syntax problems');␊
            }␊
            $tmp_content['web']['allow_push'] = $allow_push;␊
        }␊
        else {␊
 ␊
         // Generate hgrc content ␊
         if (is_file($hgrc_file)) {␊
-            $tmp_content = parse_ini_file($hgrc_file, true);␊
+            $tmp_content = @parse_ini_file($hgrc_file, true, INI_SCANNER_RAW);␊
+            if ($tmp_content === false) {␊
+              throw new Exception('could not parse "'.$hgrc_file.'" because of syntax problems');␊
+            }␊
             $tmp_content['web']['allow_push'] = $allow_push;␊
         }␊
         else {␊