Indefero Commit Details

Date:

2010-11-08 18:11:27 (15 years 29 days ago)

Author:

Thomas Keller

Branch:

develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

d08fee129b9d90efb667d7b9831e1f18d95a85ff

Parents:

8993d2988b9c2ea5a01b03f841a29bc530d5cf20

Message:

fixed two notices which lead to corrupt zip archives

Changes:

File differences

-407
408 408
409 409
410 
410
411 411
412 412
413 413
... ...
450 450
451 451
452 452
453 
453
454 454
455 455
456 456
+    list ($name, $opt, $meth, $crc, $zlen, $len, $ofs) = $args;␊
␊
    # get attributes␊
    $comment = $opt['comment'] ? $opt['comment'] : '';␊
    $comment = isset($opt['comment']) ? $opt['comment'] : '';␊
␊
    # get dos timestamp␊
    $dts = $this->dostime($opt['time']);␊

␊
    # grab comment (if specified)␊
    $comment = '';␊
    if ($opt && $opt['comment'])␊
    if ($opt && isset($opt['comment']))␊
      $comment = $opt['comment'];␊
␊
    $fields = array(                # (from V,F of APPNOTE.TXT)␊
 ...
     list ($name, $opt, $meth, $crc, $zlen, $len, $ofs) = $args;␊
 ␊
     # get attributes␊
-    $comment = $opt['comment'] ? $opt['comment'] : '';␊
+    $comment = isset($opt['comment']) ? $opt['comment'] : '';␊
 ␊
     # get dos timestamp␊
     $dts = $this->dostime($opt['time']);␊
 ␊
     # grab comment (if specified)␊
     $comment = '';␊
-    if ($opt && $opt['comment'])␊
+    if ($opt && isset($opt['comment']))␊
       $comment = $opt['comment'];␊
 ␊
     $fields = array(                # (from V,F of APPNOTE.TXT)␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags