Indefero

Indefero Commit Details


Date:2009-05-30 13:04:43 (15 years 10 months ago)
Author:Loic d'Anterroches
Branch:develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3
Commit:cefdceba1336b26ac1435d747eccd7436bd35b9e
Parents: 1c8490be6b13b266b6e8840a349576ca8be61879
Message:Fixed issue 229, code review broken with new SCM backend.
Changes:

File differences

src/IDF/Views/Review.php
207207
208208
209209
210
210
211211
212212
213213
......
215215
216216
217217
218
218
219219
220220
221221
        $files = array();␊
        $reviewers = array();␊
        foreach ($diff->files as $filename => $def) {␊
            $fileinfo = $scm->getFileInfo($filename, $patch->get_commit()->scm_id);␊
            $fileinfo = $scm->getPathInfo($filename, $patch->get_commit()->scm_id);␊
            $sql = new Pluf_SQL('cfile=%s', array($filename));␊
            $cts = $patch->get_filecomments_list(array('filter'=>$sql->gen(),␊
                                                'order'=>'creation_dtime ASC'));␊
                $reviewers[] = $ct->get_submitter();␊
            }␊
            if (count($def['chunks'])) { ␊
                $orig_file = ($fileinfo) ? $scm->getBlob($fileinfo) : '';␊
                $orig_file = ($fileinfo) ? $scm->getFile($fileinfo) : '';␊
                $files[$filename] = array(␊
                                          $diff->fileCompare($orig_file, $def, $filename),␊
                                          $form->f->{md5($filename)},␊

Archive Download the corresponding diff file

Page rendered in 0.20889s using 14 queries.