Indefero Commit Details

Date:

2011-03-17 20:33:54 (14 years 1 month ago)

Author:

Dmitry Dulepov

Branch:

develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, release-1.1, release-1.2, release-1.3

Commit:

be39d72d3c2823d9696561d1f3eef8cc13276fa6

Parents:

045eb766f1f4a560ffbf0f03634aa7de98cfb5ef

Message:

Fix XML parsing exceptions when revisions with empty log messages are parsed.

This fixes issue 518; Dmitry is added to AUTHORS.

Changes:

File differences

-7
8 8
9 9
10
10 11
11 12
12 13
+    Ludovic Bellière␊
    bohwaz <http://bohwaz.net/>␊
    Adrien Bustany␊
    Dmitry Dulepov␊
    Baptiste Durand-Bret␊
    Manuel Eidenberger <eidenberger@gmail.com>␊
    Raphaël Emourgeon␊
     Ludovic Bellière␊
     bohwaz <http://bohwaz.net/>␊
     Adrien Bustany␊
+    Dmitry Dulepov␊
     Baptiste Durand-Bret␊
     Manuel Eidenberger <eidenberger@gmail.com>␊
     Raphaël Emourgeon␊

-37
38 38
39 39
40
40 41
41 42
42 43
+- Add more file extensions supported by our in-tree prettify version (issues 490 and 567)␊
- Do not clean `<ins>` and `<del>` HTML markup from user input (issue 509)␊
- Improve HTML validation by switching from `strict` to `transitional` DOCTYPE (issue 511)␊
- Ignore XML parsing problems when trying to retrieve commit messages for svn (issue 518)␊
- Properly handle git commits without a changelog title (issue 520)␊
- Improve BSD compatibility in shell scripts (issue 526)␊
- Properly render inner whitespaces in viewed issue attachments (issue 528)␊
 - Add more file extensions supported by our in-tree prettify version (issues 490 and 567)␊
 - Do not clean `<ins>` and `<del>` HTML markup from user input (issue 509)␊
 - Improve HTML validation by switching from `strict` to `transitional` DOCTYPE (issue 511)␊
+- Ignore XML parsing problems when trying to retrieve commit messages for svn (issue 518)␊
 - Properly handle git commits without a changelog title (issue 520)␊
 - Improve BSD compatibility in shell scripts (issue 526)␊
 - Properly render inner whitespaces in viewed issue attachments (issue 528)␊

-266
267 267
268 268
269 
270 
269
270
271
272
273
274
275
271 276
272 277
273 278
+                       escapeshellarg($this->repo),␊
                       escapeshellarg($rev));␊
        $cmd = Pluf::f('idf_exec_cmd_prefix', '').$cmd;␊
        $xml = simplexml_load_string(self::shell_exec('IDF_Scm_Svn::getCommitMessage', $cmd));␊
        $this->cache['commitmess'][$rev] = (string) $xml->logentry->msg;␊
        try {␊
            $xml = simplexml_load_string(self::shell_exec('IDF_Scm_Svn::getCommitMessage', $cmd));␊
            $this->cache['commitmess'][$rev] = (string) $xml->logentry->msg;␊
        }␊
        catch (Exception $e) {␊
            $this->cache['commitmess'][$rev] = '';␊
        }␊
        return $this->cache['commitmess'][$rev];␊
    }␊
␊
                        escapeshellarg($this->repo),␊
                        escapeshellarg($rev));␊
         $cmd = Pluf::f('idf_exec_cmd_prefix', '').$cmd;␊
-        $xml = simplexml_load_string(self::shell_exec('IDF_Scm_Svn::getCommitMessage', $cmd));␊
-        $this->cache['commitmess'][$rev] = (string) $xml->logentry->msg;␊
+        try {␊
+            $xml = simplexml_load_string(self::shell_exec('IDF_Scm_Svn::getCommitMessage', $cmd));␊
+            $this->cache['commitmess'][$rev] = (string) $xml->logentry->msg;␊
+        }␊
+        catch (Exception $e) {␊
+            $this->cache['commitmess'][$rev] = '';␊
+        }␊
         return $this->cache['commitmess'][$rev];␊
     }␊
 ␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags