Indefero Commit Details

Date:

2010-02-19 10:43:29 (14 years 10 months ago)

Author:

Loic d'Anterroches

Branch:

develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

a5a5c7b2b64190513e94fc49eb8c3d79e6576f71

Parents:

c486ca928b97c2ad133b56d507fee86157962c3f

Message:

Fixed security issue, read access on a git project marked as private and source access marked as login in/all access.

Changes:

File differences

-162
163 163
164 164
165 
165
166 166
167 167
168 168
+        $request->user = $user;␊
        $request->conf = $conf;␊
        $request->project = $project;␊
        if (true === IDF_Precondition::accessTabGeneric($request, 'source_access_rights')) {␊
        if (true === IDF_Precondition::accessSource($request)) {␊
            if ($mode == 'readonly') {␊
                return array(Pluf::f('idf_plugin_syncgit_base_repositories', '/home/git/repositories'),␊
                             $project->shortname);␊
         $request->user = $user;␊
         $request->conf = $conf;␊
         $request->project = $project;␊
-        if (true === IDF_Precondition::accessTabGeneric($request, 'source_access_rights')) {␊
+        if (true === IDF_Precondition::accessSource($request)) {␊
             if ($mode == 'readonly') {␊
                 return array(Pluf::f('idf_plugin_syncgit_base_repositories', '/home/git/repositories'),␊
                              $project->shortname);␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags