Indefero Commit Details

Date:

2011-08-17 13:17:14 (13 years 8 months ago)

Author:

Thomas Keller

Branch:

develop, feature.diff-whitespace, feature.issue-of-others, feature.search-filter, feature.webrepos, feature.wiki-default-page, release-1.2, release-1.3

Commit:

a2c832a130e6063201a627efa9361f0d80f97cd9

Parents:

b17de014ec5c0c6431667aa428903e633562d598

Message:

Improve the 'parents' parsing for git and ignore any empty parts; also react gracefully if we could not parse the parents for some weird reason.

Changes:

File differences

-37
38 38
39 39
40
41
40 42
41 43
42 44
+  and only display this list if there are any branches available for all SCMs␊
- If git's author name is not encoded in an UTF-8 compatible encoding, skip the author lookup,␊
  as we have no information what the author string is actually encoded in␊
- Indefero no longer displays an empty parents paragraph in the commit view for root revisions of␊
  a git repository␊
␊
## Documentation␊
␊
   and only display this list if there are any branches available for all SCMs␊
 - If git's author name is not encoded in an UTF-8 compatible encoding, skip the author lookup,␊
   as we have no information what the author string is actually encoded in␊
+- Indefero no longer displays an empty parents paragraph in the commit view for root revisions of␊
+  a git repository␊
 ␊
 ## Documentation␊
 ␊

-646
647 647
648 648
649 
649
650
651
652
653
650 654
651 655
652 656
+        $c['full_message'] = IDF_Commit::toUTF8($c['full_message']);␊
        $c['title'] = IDF_Commit::toUTF8($c['title']);␊
        if (isset($c['parents'])) {␊
            $c['parents'] = explode(' ', trim($c['parents']));␊
            $c['parents'] = preg_split('/ /', trim($c['parents']), -1, PREG_SPLIT_NO_EMPTY);␊
        } else {␊
            // this is actually an error state because we should _always_␊
            // be able to parse the parents line with every git version␊
            $c['parents'] = null;␊
        }␊
        $res[] = (object) $c;␊
        return $res;␊
         $c['full_message'] = IDF_Commit::toUTF8($c['full_message']);␊
         $c['title'] = IDF_Commit::toUTF8($c['title']);␊
         if (isset($c['parents'])) {␊
-            $c['parents'] = explode(' ', trim($c['parents']));␊
+            $c['parents'] = preg_split('/ /', trim($c['parents']), -1, PREG_SPLIT_NO_EMPTY);␊
+        } else {␊
+            // this is actually an error state because we should _always_␊
+            // be able to parse the parents line with every git version␊
+            $c['parents'] = null;␊
         }␊
         $res[] = (object) $c;␊
         return $res;␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags