Indefero Commit Details

Date:

2009-02-01 02:54:09 (15 years 10 months ago)

Author:

Loic d'Anterroches

Branch:

dev, develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

a116c27c036ba94fd1616035f29090d5cad62450

Parents:

a1ecb4c0b070c23362a1646544ce9a08008e540b

Message:

Fixed issue 124, JS dropdown lists not working in Issues page under IE 7 & 8.

IE does not like trailing comma in an array.
Bad: [1, 2, 3,] Good: [1, 2, 3]

Changes:

File differences

-241
242 242
243 243
244 
244
245 245
246 246
247 247
+            $auto .= sprintf('{ name: "%s", to: "%s" }, ',␊
                             Pluf_esc($d), Pluf_esc($v));␊
        }␊
        return substr($auto, 0, -1);␊
        return substr($auto, 0, -2);␊
    }␊
␊
    /**␊
             $auto .= sprintf('{ name: "%s", to: "%s" }, ',␊
                              Pluf_esc($d), Pluf_esc($v));␊
         }␊
-        return substr($auto, 0, -1);␊
+        return substr($auto, 0, -2);␊
     }␊
 ␊
     /**␊

-549
550 550
551 551
552 
552
553 553
554 554
555 555
... ...
565 565
566 566
567 567
568 
568
569 569
570 570
571 571
+                                       Pluf_esc($d),␊
                                       Pluf_esc($v));␊
            }␊
            $auto[$key] = substr($auto[$key], 0, -1);␊
            $auto[$key] = substr($auto[$key], 0, -2);␊
        }␊
        // Get the members/owners␊
        $m = $project->getMembershipData();␊

                                           Pluf_esc($owner),␊
                                           Pluf_esc($owner->login));␊
        }␊
        $auto['auto_owner'] = substr($auto['auto_owner'], 0, -1);␊
        $auto['auto_owner'] = substr($auto['auto_owner'], 0, -2);␊
        unset($auto['_auto_owner']);␊
        return $auto;␊
    }␊
 ...
                                        Pluf_esc($d),␊
                                        Pluf_esc($v));␊
             }␊
-            $auto[$key] = substr($auto[$key], 0, -1);␊
+            $auto[$key] = substr($auto[$key], 0, -2);␊
         }␊
         // Get the members/owners␊
         $m = $project->getMembershipData();␊
                                            Pluf_esc($owner),␊
                                            Pluf_esc($owner->login));␊
         }␊
-        $auto['auto_owner'] = substr($auto['auto_owner'], 0, -1);␊
+        $auto['auto_owner'] = substr($auto['auto_owner'], 0, -2);␊
         unset($auto['_auto_owner']);␊
         return $auto;␊
     }␊

-407
408 408
409 409
410 
410
411 411
412 412
413 413
+            $auto .= sprintf('{ name: "%s", to: "%s" }, ',␊
                             Pluf_esc($d), Pluf_esc($v));␊
        }␊
        return substr($auto, 0, -1);␊
        return substr($auto, 0, -2);␊
    }␊
}␊
␊
             $auto .= sprintf('{ name: "%s", to: "%s" }, ',␊
                              Pluf_esc($d), Pluf_esc($v));␊
         }␊
-        return substr($auto, 0, -1);␊
+        return substr($auto, 0, -2);␊
     }␊
 }␊
 ␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags