Indefero Commit Details

Date:

2011-10-03 17:47:31 (14 years 2 months ago)

Author:

Thomas Keller

Branch:

develop, feature.diff-whitespace, feature.search-filter, feature.wiki-default-page, release-1.2, release-1.3

Commit:

9a8bd464a33774741133eb1a36b6d11c8800dfc0

Parents:

9e2ea7404b46d53b558c290613e6cf85fe9e0f40

Message:

Remove a couple of unused calls to get a list of project tags; these calls are currently done from within the tags-cloud template most of the time, which is ugly, but the way it works as of now.

Changes:

File differences

-319
320 320
321 321
322 
323 322
324 323
325 324
326 325
327 326
328 
329 327
330 328
331 329
+        $pag->no_results_text = __('No downloads were found.');␊
        $pag->sort_order = array('creation_dtime', 'DESC');␊
        $pag->setFromRequest($request);␊
        $tags = $prj->getTagCloud('downloads');␊
        return Pluf_Shortcuts_RenderToResponse('idf/downloads/index.html',␊
                                               array(␊
                                                     'page_title' => $title,␊
                                                     'label' => $tag,␊
                                                     'downloads' => $pag,␊
                                                     'tags' => $tags,␊
                                                     'dlabel' => $dtag,␊
                                                     ),␊
                                               $request);␊
         $pag->no_results_text = __('No downloads were found.');␊
         $pag->sort_order = array('creation_dtime', 'DESC');␊
         $pag->setFromRequest($request);␊
-        $tags = $prj->getTagCloud('downloads');␊
         return Pluf_Shortcuts_RenderToResponse('idf/downloads/index.html',␊
                                                array(␊
                                                      'page_title' => $title,␊
                                                      'label' => $tag,␊
                                                      'downloads' => $pag,␊
-                                                     'tags' => $tags,␊
                                                      'dlabel' => $dtag,␊
                                                      ),␊
                                                $request);␊

-152
153 153
154 154
155 
156 155
157 156
158 157
159 158
160 159
161 
162 160
163 161
164 162
+        $pag->items_per_page = 25;␊
        $pag->no_results_text = __('No documentation pages were found.');␊
        $pag->setFromRequest($request);␊
        $tags = $prj->getTagCloud('wiki');␊
        return Pluf_Shortcuts_RenderToResponse('idf/wiki/index.html',␊
                                               array(␊
                                                     'page_title' => $title,␊
                                                     'label' => $tag,␊
                                                     'pages' => $pag,␊
                                                     'tags' => $tags,␊
                                                     'dlabel' => $dtag,␊
                                                     ),␊
                                               $request);␊
         $pag->items_per_page = 25;␊
         $pag->no_results_text = __('No documentation pages were found.');␊
         $pag->setFromRequest($request);␊
-        $tags = $prj->getTagCloud('wiki');␊
         return Pluf_Shortcuts_RenderToResponse('idf/wiki/index.html',␊
                                                array(␊
                                                      'page_title' => $title,␊
                                                      'label' => $tag,␊
                                                      'pages' => $pag,␊
-                                                     'tags' => $tags,␊
                                                      'dlabel' => $dtag,␊
                                                      ),␊
                                                $request);␊

-5
6 6
7 7
8 
9 8
10 
11 
12 
13 
14 
15 
16 
17 
18 
19 
20 
21
+{if !$user.isAnonymous()}␊
{aurl 'url', 'IDF_Views_Review::create', array($project.shortname)}␊
<p><a href="{$url}"><img style="vertical-align: text-bottom;" src="{media '/idf/img/add.png'}" alt="+" align="bottom" /></a> <a href="{$url}">{trans 'Start Code Review'}</a></p>{/if}␊
␊
{/block}␊
{block context}␊
{*␊
{aurl 'open_url', 'IDF_Views_Issue::index', array($project.shortname)}␊
{aurl 'closed_url', 'IDF_Views_Issue::listStatus', array($project.shortname, 'closed')}␊
{blocktrans}<p><strong>Open issues:</strong> <a href="{$open_url}">{$open}</a></p>␊
<p><strong>Closed issues:</strong> <a href="{$closed_url}">{$closed}</a></p>{/blocktrans}␊
{assign $class = ''}{assign $i = 0}␊
<p class="smaller">{foreach $project.getTagCloud($cloud) as $label}␊
{aurl 'url', 'IDF_Views_Issue::listLabel', array($project.shortname, $label.id, 'open')}␊
{if $class != $label.class}{if $i != 0}<br />{/if}<strong class="label">{$label.class}:</strong> {/if}␊
<a href="{$url}" class="label">{$label.name}</a>,{assign $class = $label.class}{assign $i = $i + 1}{/foreach}</p>␊
*}{/block}␊
 {if !$user.isAnonymous()}␊
 {aurl 'url', 'IDF_Views_Review::create', array($project.shortname)}␊
 <p><a href="{$url}"><img style="vertical-align: text-bottom;" src="{media '/idf/img/add.png'}" alt="+" align="bottom" /></a> <a href="{$url}">{trans 'Start Code Review'}</a></p>{/if}␊
-␊
 {/block}␊
-{block context}␊
-{*␊
-{aurl 'open_url', 'IDF_Views_Issue::index', array($project.shortname)}␊
-{aurl 'closed_url', 'IDF_Views_Issue::listStatus', array($project.shortname, 'closed')}␊
-{blocktrans}<p><strong>Open issues:</strong> <a href="{$open_url}">{$open}</a></p>␊
-<p><strong>Closed issues:</strong> <a href="{$closed_url}">{$closed}</a></p>{/blocktrans}␊
-{assign $class = ''}{assign $i = 0}␊
-<p class="smaller">{foreach $project.getTagCloud($cloud) as $label}␊
-{aurl 'url', 'IDF_Views_Issue::listLabel', array($project.shortname, $label.id, 'open')}␊
-{if $class != $label.class}{if $i != 0}<br />{/if}<strong class="label">{$label.class}:</strong> {/if}␊
-<a href="{$url}" class="label">{$label.name}</a>,{assign $class = $label.class}{assign $i = $i + 1}{/foreach}</p>␊
-*}{/block}␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags