Indefero Commit Details

Date:

2010-06-22 17:22:10 (14 years 5 months ago)

Author:

Thomas Keller

Branch:

develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

9a8148079df4f8357d054260c43cc9adc5c40e4a

Parents:

24762adecc802bc557cb2cd218d1445afbebba11

Message:

prevent endless redirection if a requested branch does not exist, i.e. has no matching revisions

Changes:

File differences

-420
421 421
422 422
423 
423
424
424 425
425 426
426 427
... ...
431 432
432 433
433 434
435
436
437
438
439
440
441
442
434 443
435 444
436 445
+␊
    /**␊
     * monotone has no concept of a "main" branch, so just return␊
     * the confiured one␊
     * the configured one. Ensure however that we can select revisions␊
     * with it at all.␊
     *␊
     * @see IDF_Scm::getMainBranch()␊
     */␊

            || empty($branch)) {␊
            $branch = "*";␊
        }␊
␊
        if (count($this->_resolveSelector("h:$branch")) == 0)␊
        {␊
            throw new IDF_Scm_Exception(␊
                "Branch $branch is empty"␊
            );␊
        }␊
␊
        return $branch;␊
    }␊
␊
 ...
 ␊
     /**␊
      * monotone has no concept of a "main" branch, so just return␊
-     * the confiured one␊
+     * the configured one. Ensure however that we can select revisions␊
+     * with it at all.␊
      *␊
      * @see IDF_Scm::getMainBranch()␊
      */␊
             || empty($branch)) {␊
             $branch = "*";␊
         }␊
+␊
+        if (count($this->_resolveSelector("h:$branch")) == 0)␊
+        {␊
+            throw new IDF_Scm_Exception(␊
+                "Branch $branch is empty"␊
+            );␊
+        }␊
+␊
         return $branch;␊
     }␊
 ␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags