Indefero Commit Details

Date:

2008-11-27 02:03:21 (16 years 25 days ago)

Author:

Loic d'Anterroches

Branch:

dev, develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

83fd312c816332fb275dd097750e603406c0cb93

Parents:

f9b6a022c8fdb89e6e39b7c8fc53c497e96877e8

Message:

Added an exception when the scm command fails.

This will help the debugging for people.

Changes:

File differences

-55
56 56
57 57
58
59
60
58 61
59 62
60 63
+        $cache = Pluf_Cache::factory();␊
        if (null === ($res=$cache->get($key))) {␊
            $ll = exec($command, $output, $return);␊
            if ($return != 0) {␊
                throw new IDF_Scm_Exception(sprintf('Error when running command: "%s", return code: %d', $command, $return));␊
            }␊
            $cache->set($key, array($ll, $return, $output));␊
        } else {␊
            list($ll, $return, $output) = $res;␊
         $cache = Pluf_Cache::factory();␊
         if (null === ($res=$cache->get($key))) {␊
             $ll = exec($command, $output, $return);␊
+            if ($return != 0) {␊
+                throw new IDF_Scm_Exception(sprintf('Error when running command: "%s", return code: %d', $command, $return));␊
+            }␊
             $cache->set($key, array($ll, $return, $output));␊
         } else {␊
             list($ll, $return, $output) = $res;␊

-
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
+<?php␊
/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */␊
/*␊
# ***** BEGIN LICENSE BLOCK *****␊
# This file is part of InDefero, an open source project management application.␊
# Copyright (C) 2008 Céondo Ltd and contributors.␊
#␊
# InDefero is free software; you can redistribute it and/or modify␊
# it under the terms of the GNU General Public License as published by␊
# the Free Software Foundation; either version 2 of the License, or␊
# (at your option) any later version.␊
#␊
# InDefero is distributed in the hope that it will be useful,␊
# but WITHOUT ANY WARRANTY; without even the implied warranty of␊
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the␊
# GNU General Public License for more details.␊
#␊
# You should have received a copy of the GNU General Public License␊
# along with this program; if not, write to the Free Software␊
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA␊
#␊
# ***** END LICENSE BLOCK ***** */␊
␊
class IDF_Scm_Exception extends Exception␊
{␊
}
+<?php␊
+/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */␊
+/*␊
+# ***** BEGIN LICENSE BLOCK *****␊
+# This file is part of InDefero, an open source project management application.␊
+# Copyright (C) 2008 Céondo Ltd and contributors.␊
+#␊
+# InDefero is free software; you can redistribute it and/or modify␊
+# it under the terms of the GNU General Public License as published by␊
+# the Free Software Foundation; either version 2 of the License, or␊
+# (at your option) any later version.␊
+#␊
+# InDefero is distributed in the hope that it will be useful,␊
+# but WITHOUT ANY WARRANTY; without even the implied warranty of␊
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the␊
+# GNU General Public License for more details.␊
+#␊
+# You should have received a copy of the GNU General Public License␊
+# along with this program; if not, write to the Free Software␊
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA␊
+#␊
+# ***** END LICENSE BLOCK ***** */␊
+␊
+class IDF_Scm_Exception extends Exception␊
+{␊
+}

Download the corresponding diff file

Indefero

File differences

Branches

Tags