Indefero

Indefero Commit Details


Date:2012-04-18 17:14:10 (12 years 8 months ago)
Author:Thomas Keller
Branch:develop, release-1.3
Commit:75f62663a9f73d275d66da7e2c869dfaa681e7e7
Parents: 169fbe62162b449b95c87fe75af20b9b466dff05
Message:Make the project field in the tags table nullable so it is (hopefully) optional on setups with enabled foreign key constraints.
Changes:

File differences

src/IDF/Forge.php
5353
5454
5555
56
56
5757
5858
5959
......
9292
9393
9494
95
95
}␊
␊
public function getProjectLabelsWithCounts() {␊
$sql = new Pluf_SQL('project=0');␊
$sql = new Pluf_SQL('project IS NULL');␊
$tagList = Pluf::factory('IDF_Tag')->getList(array(␊
'filter' => $sql->gen(),␊
'view' => 'join_projects',␊
public function setCustomForgePageContent($content) {␊
$this->conf->setVal('custom_forge_page_content', $content);␊
}␊
}
}␊
src/IDF/Migrations/25NullableProjectInTag.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
<?php␊
/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */␊
/*␊
# ***** BEGIN LICENSE BLOCK *****␊
# This file is part of InDefero, an open source project management application.␊
# Copyright (C) 2008-2011 Céondo Ltd and contributors.␊
#␊
# InDefero is free software; you can redistribute it and/or modify␊
# it under the terms of the GNU General Public License as published by␊
# the Free Software Foundation; either version 2 of the License, or␊
# (at your option) any later version.␊
#␊
# InDefero is distributed in the hope that it will be useful,␊
# but WITHOUT ANY WARRANTY; without even the implied warranty of␊
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the␊
# GNU General Public License for more details.␊
#␊
# You should have received a copy of the GNU General Public License␊
# along with this program; if not, write to the Free Software␊
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA␊
#␊
# ***** END LICENSE BLOCK ***** */␊
␊
function IDF_Migrations_25NullableProjectInTag_up($params=null)␊
{␊
$engine = Pluf::f('db_engine');␊
$db = Pluf::db();␊
␊
if ($engine === 'PostgreSQL') {␊
$db->execute('ALTER TABLE '.$db->pfx.'idf_tags ALTER COLUMN project DROP NOT NULL');␊
} else if ($engine === 'MySQL') {␊
$db->execute('ALTER TABLE '.$db->pfx.'idf_tags MODIFY project MEDIUMINT NULL');␊
// this is only needed for non-transactional setups where MySQL set 0 as default value␊
$db->execute('UPDATE '.$db->pfx.'idf_tags SET project=NULL WHERE project=0');␊
}␊
}␊
␊
function IDF_Migrations_25NullableProjectInTag_down($params=null)␊
{␊
$db = Pluf::db();␊
if ($engine === 'PostgreSQL') {␊
$db->execute('ALTER TABLE '.$db->pfx.'idf_tags ALTER COLUMN project SET NOT NULL');␊
} else if ($engine === 'MySQL') {␊
$db->execute('ALTER TABLE '.$db->pfx.'idf_tags MODIFY project MEDIUMINT NOT NULL');␊
}␊
}␊
src/IDF/Tag.php
4848
4949
5050
51
51
52
5253
5354
5455
......
147148
148149
149150
150
151
151152
152153
153154
array(␊
'type' => 'Pluf_DB_Field_Foreignkey',␊
'model' => 'IDF_Project',␊
'blank' => false,␊
'blank' => true,␊
'is_null' => true,␊
'verbose' => __('project'),␊
),␊
'class' =>␊
$class = trim($class);␊
$name = trim($name);␊
$gtag = new IDF_Tag();␊
$sql = new Pluf_SQL('class=%s AND lcname=%s AND project=0',␊
$sql = new Pluf_SQL('class=%s AND lcname=%s AND project IS NULL',␊
array($class, mb_strtolower($name)));␊
$tags = $gtag->getList(array('filter' => $sql->gen()));␊
if ($tags->count() < 1) {␊
src/IDF/Template/MarkdownForge.php
8383
8484
8585
86
86
8787
8888
8989
$name = $class;␊
$class = IDF_TAG_DEFAULT_CLASS;␊
}␊
$sql = new Pluf_SQL('class=%s AND lcname=%s AND project=0',␊
$sql = new Pluf_SQL('class=%s AND lcname=%s AND project IS NULL',␊
array(strtolower($class), mb_strtolower($name)));␊
$tag = Pluf::factory('IDF_Tag')->getOne(array('filter' => $sql->gen()));␊
}␊

Archive Download the corresponding diff file

Page rendered in 0.08674s using 13 queries.