Indefero Commit Details

Date:

2008-11-25 02:38:10 (16 years 4 months ago)

Author:

Loic d'Anterroches

Branch:

dev, develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

6bee793704e44dc8084b863edb54c98d2ab931f9

Parents:

70616a0c9521ca1e07671fd258e37adc519d0f95

Message:

Added permission at the installation/upgrade for cleaner code.

The authorized user permission is added at the installation/upgrade step
to remove the code to remove the unncessary logic in the code.

Changes:

File differences

-78
79 79
80 80
81 
82 
83 
84 
85 
86 
87 
88 
89 
90 
91 81
92 82
93 83
+        }␊
        // remove all the permissions␊
        $perm = Pluf_Permission::getFromString('IDF.project-authorized-user');␊
        if ($perm == false) {␊
            // We do not have this perm for the moment in the system,␊
            // so create it.␊
            $perm = new Pluf_Permission();␊
            $perm->name = 'Project authorized users';␊
            $perm->code_name = 'project-authorized-user';␊
            $perm->description = 'Permission given to users allowed to access a project.';␊
            $perm->application = 'IDF';␊
            $perm->create();␊
        }␊
        $cm = $this->project->getMembershipData();␊
        $guser = new Pluf_User();␊
        foreach ($cm['authorized'] as $user) {␊
         }␊
         // remove all the permissions␊
         $perm = Pluf_Permission::getFromString('IDF.project-authorized-user');␊
-        if ($perm == false) {␊
-            // We do not have this perm for the moment in the system,␊
-            // so create it.␊
-            $perm = new Pluf_Permission();␊
-            $perm->name = 'Project authorized users';␊
-            $perm->code_name = 'project-authorized-user';␊
-            $perm->description = 'Permission given to users allowed to access a project.';␊
-            $perm->application = 'IDF';␊
-            $perm->create();␊
-        }␊
         $cm = $this->project->getMembershipData();␊
         $guser = new Pluf_User();␊
         foreach ($cm['authorized'] as $user) {␊

-37
38 38
39 39
40
41
42
43
44
45
40 46
41 47
42 48
43 49
50
51
44 52
45 53
46 54
... ...
51 59
52 60
53 61
62
54 63
+        throw new Exception('SQLite complex migration not supported.');␊
    }␊
    $db->execute($sql[$engine]);␊
    $perm = new Pluf_Permission();␊
    $perm->name = 'Project authorized users';␊
    $perm->code_name = 'project-authorized-user';␊
    $perm->description = 'Permission given to users allowed to access a project.';␊
    $perm->application = 'IDF';␊
    $perm->create();␊
}␊
␊
function IDF_Migrations_6PrivateProject_down($params=null)␊
{␊
    $perm = Pluf_Permission::getFromString('IDF.project-authorized-user');␊
    if ($perm) $perm->delete();␊
    $table = Pluf::factory('IDF_Project')->getSqlTable();␊
    $sql = array();␊
    $sql['PostgreSQL'] = 'ALTER TABLE '.$table.' DROP COLUMN "private"';␊

        throw new Exception('SQLite complex migration not supported.');␊
    }␊
    $db->execute($sql[$engine]);␊
␊
}
 ...
         throw new Exception('SQLite complex migration not supported.');␊
     }␊
     $db->execute($sql[$engine]);␊
+    $perm = new Pluf_Permission();␊
+    $perm->name = 'Project authorized users';␊
+    $perm->code_name = 'project-authorized-user';␊
+    $perm->description = 'Permission given to users allowed to access a project.';␊
+    $perm->application = 'IDF';␊
+    $perm->create();␊
 }␊
 ␊
 function IDF_Migrations_6PrivateProject_down($params=null)␊
 {␊
+    $perm = Pluf_Permission::getFromString('IDF.project-authorized-user');␊
+    if ($perm) $perm->delete();␊
     $table = Pluf::factory('IDF_Project')->getSqlTable();␊
     $sql = array();␊
     $sql['PostgreSQL'] = 'ALTER TABLE '.$table.' DROP COLUMN "private"';␊
         throw new Exception('SQLite complex migration not supported.');␊
     }␊
     $db->execute($sql[$engine]);␊
+␊
 }

-62
63 63
64 64
65
66
67
68
69
70
65 71
66 72
67 73
... ...
70 76
71 77
72 78
79
80
73 81
74 82
75 83
+    $perm->description = 'Permission given to project owners.';␊
    $perm->application = 'IDF';␊
    $perm->create();␊
    $perm = new Pluf_Permission();␊
    $perm->name = 'Project authorized users';␊
    $perm->code_name = 'project-authorized-user';␊
    $perm->description = 'Permission given to users allowed to access a project.';␊
    $perm->application = 'IDF';␊
    $perm->create();␊
}␊
␊
function IDF_Migrations_Install_teardown($params=null)␊

    if ($perm) $perm->delete();␊
    $perm = Pluf_Permission::getFromString('IDF.project-owner');␊
    if ($perm) $perm->delete();␊
    $perm = Pluf_Permission::getFromString('IDF.project-authorized-user');␊
    if ($perm) $perm->delete();␊
    $models = array(␊
                    'IDF_WikiRevision',␊
                    'IDF_WikiPage',␊
 ...
     $perm->description = 'Permission given to project owners.';␊
     $perm->application = 'IDF';␊
     $perm->create();␊
+    $perm = new Pluf_Permission();␊
+    $perm->name = 'Project authorized users';␊
+    $perm->code_name = 'project-authorized-user';␊
+    $perm->description = 'Permission given to users allowed to access a project.';␊
+    $perm->application = 'IDF';␊
+    $perm->create();␊
 }␊
 ␊
 function IDF_Migrations_Install_teardown($params=null)␊
     if ($perm) $perm->delete();␊
     $perm = Pluf_Permission::getFromString('IDF.project-owner');␊
     if ($perm) $perm->delete();␊
+    $perm = Pluf_Permission::getFromString('IDF.project-authorized-user');␊
+    if ($perm) $perm->delete();␊
     $models = array(␊
                     'IDF_WikiRevision',␊
                     'IDF_WikiPage',␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags