Indefero Commit Details

Date:

2008-12-05 04:53:22 (16 years 17 days ago)

Author:

Loic d'Anterroches

Branch:

dev, develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

5bd4fed8f4db5b426e8e18a1d3f6cd2b759f7e02

Parents:

6ae032df3e84bab8eedc9d18637dbb511a37d578

Message:

Updated to simplify the configuration.

We do not need to have the extra tags and modifiers in the configuration
as a signal is taking care of that. That way we can add new tags,
modifiers without the need to update the configuration settings.

Changes:

File differences

-69
70 70
71 71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
72 95
73 96
74 97
+            $request->rights[$val] = (true === IDF_Precondition::accessTabGeneric($request, $key));␊
        }␊
    }␊
␊
    /**␊
     * Update the template tags and modifiers to not have them in the config.␊
     *␊
     * This is here at the moment because we do not want to put that␊
     * in a IDF_Template class just for one method.␊
     *␊
     */␊
    public static function updateTemplateTagsModifiers($sender, &$params)␊
    {␊
        $params['tags'] = array_merge($params['tags'],␊
                                      array(␊
                              'hotkey' => 'IDF_Template_HotKey',␊
                              'issuetext' => 'IDF_Template_IssueComment',␊
                              'timeline' => 'IDF_Template_TimelineFragment',␊
                              'markdown' => 'IDF_Template_Markdown',␊
                                            ));␊
        $params['modifiers'] = array_merge($params['modifiers'],␊
                                           array(␊
                                   'size' => 'IDF_Views_Source_PrettySize',␊
                                   'ssize' => 'IDF_Views_Source_PrettySizeSimple',␊
                                                 ));␊
    }␊
}␊
␊
␊
             $request->rights[$val] = (true === IDF_Precondition::accessTabGeneric($request, $key));␊
         }␊
     }␊
+␊
+    /**␊
+     * Update the template tags and modifiers to not have them in the config.␊
+     *␊
+     * This is here at the moment because we do not want to put that␊
+     * in a IDF_Template class just for one method.␊
+     *␊
+     */␊
+    public static function updateTemplateTagsModifiers($sender, &$params)␊
+    {␊
+        $params['tags'] = array_merge($params['tags'],␊
+                                      array(␊
+                              'hotkey' => 'IDF_Template_HotKey',␊
+                              'issuetext' => 'IDF_Template_IssueComment',␊
+                              'timeline' => 'IDF_Template_TimelineFragment',␊
+                              'markdown' => 'IDF_Template_Markdown',␊
+                                            ));␊
+        $params['modifiers'] = array_merge($params['modifiers'],␊
+                                           array(␊
+                                   'size' => 'IDF_Views_Source_PrettySize',␊
+                                   'ssize' => 'IDF_Views_Source_PrettySizeSimple',␊
+                                                 ));␊
+    }␊
 }␊
 ␊
 ␊

-179
180 180
181 181
182 
183 
184 
185 
186 
187 
188 
189 
190 
191 
192 182
193 183
194 184
+         );␊
$cfg['template_context_processors'] = array('IDF_Middleware_ContextPreProcessor');␊
$cfg['idf_views'] = dirname(__FILE__).'/urls.php';␊
$cfg['template_tags'] = array(␊
                              'hotkey' => 'IDF_Template_HotKey',␊
                              'issuetext' => 'IDF_Template_IssueComment',␊
                              'timeline' => 'IDF_Template_TimelineFragment',␊
                              'markdown' => 'IDF_Template_Markdown',␊
                              );␊
$cfg['template_modifiers'] = array(␊
                                   'size' => 'IDF_Views_Source_PrettySize',␊
                                   'ssize' => 'IDF_Views_Source_PrettySizeSimple',␊
                                   );␊
␊
# available languages␊
$cfg['languages'] = array('en', 'fr'); ␊
          );␊
 $cfg['template_context_processors'] = array('IDF_Middleware_ContextPreProcessor');␊
 $cfg['idf_views'] = dirname(__FILE__).'/urls.php';␊
-$cfg['template_tags'] = array(␊
-                              'hotkey' => 'IDF_Template_HotKey',␊
-                              'issuetext' => 'IDF_Template_IssueComment',␊
-                              'timeline' => 'IDF_Template_TimelineFragment',␊
-                              'markdown' => 'IDF_Template_Markdown',␊
-                              );␊
-$cfg['template_modifiers'] = array(␊
-                                   'size' => 'IDF_Views_Source_PrettySize',␊
-                                   'ssize' => 'IDF_Views_Source_PrettySizeSimple',␊
-                                   );␊
 ␊
 # available languages␊
 $cfg['languages'] = array('en', 'fr'); ␊

-39
40 40
41 41
42
43
44
42 45
43 46
44 47
+$m['IDF_Review_FileComment'] = array('relate_to' => array('IDF_Review_Patch', 'Pluf_User'));␊
␊
␊
Pluf_Signal::connect('Pluf_Template_Compiler::construct_template_tags_modifiers',␊
                     array('IDF_Middleware', 'updateTemplateTagsModifiers'));␊
␊
# -- Standard plugins, they will run only if configured --␊
#␊
# Subversion synchronization␊
 $m['IDF_Review_FileComment'] = array('relate_to' => array('IDF_Review_Patch', 'Pluf_User'));␊
 ␊
 ␊
+Pluf_Signal::connect('Pluf_Template_Compiler::construct_template_tags_modifiers',␊
+                     array('IDF_Middleware', 'updateTemplateTagsModifiers'));␊
+␊
 # -- Standard plugins, they will run only if configured --␊
 #␊
 # Subversion synchronization␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags