Indefero Commit Details

Date:

2008-11-27 03:03:30 (16 years 25 days ago)

Author:

Loic d'Anterroches

Branch:

dev, develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

566c90cf6a2d3ad70f9a38e58030b2ca7f3143aa

Parents:

eb60e99d5cf6c611d151e78fb1b63b6f8a4f4a31

Message:

Added full debug of Scm call only when debug flag set.

This is because git will return an error code when testing if a commit
exists and in fact does not exist. So it means that we get an exception
on all the string "commit foo" when foo is not a commit in the issue
text.

Changes:

File differences

-55
56 56
57 57
58 
58
59 59
60 60
61 61
+        $cache = Pluf_Cache::factory();␊
        if (null === ($res=$cache->get($key))) {␊
            $ll = exec($command, $output, $return);␊
            if ($return != 0) {␊
            if ($return != 0 and Pluf::f('debug', false)) {␊
                throw new IDF_Scm_Exception(sprintf('Error when running command: "%s", return code: %d', $command, $return));␊
            }␊
            $cache->set($key, array($ll, $return, $output));␊
         $cache = Pluf_Cache::factory();␊
         if (null === ($res=$cache->get($key))) {␊
             $ll = exec($command, $output, $return);␊
-            if ($return != 0) {␊
+            if ($return != 0 and Pluf::f('debug', false)) {␊
                 throw new IDF_Scm_Exception(sprintf('Error when running command: "%s", return code: %d', $command, $return));␊
             }␊
             $cache->set($key, array($ll, $return, $output));␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags