Indefero Commit Details

Date:

2012-04-26 11:01:10 (13 years 6 months ago)

Author:

Simon Holywell

Branch:

develop

Commit:

53f6133899fe58285dd8a779aa9cfd417696e498

Parents:

c3bbddb1ff394858d6e3870d2a73f69f24e5aa7d

Message:

Refactor getIssueCountByDueDate slightly

Changes:

File differences

-207
208 208
209 209
210 
210
211 211
212 
213 
214 
215 
216 
217 
218 
219 
220 
221 
222 
223 212
224 
213
225 214
226 215
227 216
+     *␊
     * @return int Count␊
     */␊
    public function getIssueCountByDueDate($due='overdue', $status='open', $label=null, $ids=array())␊
    public function getIssueCountByDueDate($due='overdue', $label=null, $ids=array())␊
    {␊
        switch ($status) {␊
        case 'open':␊
            $key = 'labels_issue_open';␊
            $default = IDF_Form_IssueTrackingConf::init_open;␊
            break;␊
        case 'closed':␊
        default:␊
            $key = 'labels_issue_closed';␊
            $default = IDF_Form_IssueTrackingConf::init_closed;␊
            break;␊
        }␊
        $tags = array();␊
        foreach ($this->getTagsFromConfig($key, $default, 'Status') as $tag) {␊
        foreach ($this->getTagsFromConfig('labels_issue_open', IDF_Form_IssueTrackingConf::init_open, 'Status') as $tag) {␊
            $tags[] = (int)$tag->id;␊
        }␊
        if (count($tags) == 0) return array();␊
      *␊
      * @return int Count␊
      */␊
-    public function getIssueCountByDueDate($due='overdue', $status='open', $label=null, $ids=array())␊
+    public function getIssueCountByDueDate($due='overdue', $label=null, $ids=array())␊
     {␊
-        switch ($status) {␊
-        case 'open':␊
-            $key = 'labels_issue_open';␊
-            $default = IDF_Form_IssueTrackingConf::init_open;␊
-            break;␊
-        case 'closed':␊
-        default:␊
-            $key = 'labels_issue_closed';␊
-            $default = IDF_Form_IssueTrackingConf::init_closed;␊
-            break;␊
-        }␊
         $tags = array();␊
-        foreach ($this->getTagsFromConfig($key, $default, 'Status') as $tag) {␊
+        foreach ($this->getTagsFromConfig('labels_issue_open', IDF_Form_IssueTrackingConf::init_open, 'Status') as $tag) {␊
             $tags[] = (int)$tag->id;␊
         }␊
         if (count($tags) == 0) return array();␊

-613
614 614
615 615
616 
616
617 617
618 618
619 619
... ...
931 931
932 932
933 933
934 
934
935 935
936 936
937 937
+        }␊
␊
        // get stats about the issues␊
        $overdue = $prj->getIssueCountByDueDate('overdue', 'open', $tag, $issue_ids);␊
        $overdue = $prj->getIssueCountByDueDate('overdue', $tag, $issue_ids);␊
        $open = $prj->getIssueCountByStatus('open', $tag, $issue_ids);␊
        $closed = $prj->getIssueCountByStatus('closed', $tag, $issue_ids);␊
␊

        // Get stats about the open/closed issues having this tag.␊
        $open = $prj->getIssueCountByStatus('open', $tag);␊
        $closed = $prj->getIssueCountByStatus('closed', $tag);␊
        $overdue = $prj->getIssueCountByDueDate('overdue', 'open', $tag);␊
        $overdue = $prj->getIssueCountByDueDate('overdue', $tag);␊
        // Paginator to paginate the issues␊
        $pag = new Pluf_Paginator(new IDF_Issue());␊
        $pag->model_view = 'join_tags';␊
 ...
         }␊
 ␊
         // get stats about the issues␊
-        $overdue = $prj->getIssueCountByDueDate('overdue', 'open', $tag, $issue_ids);␊
+        $overdue = $prj->getIssueCountByDueDate('overdue', $tag, $issue_ids);␊
         $open = $prj->getIssueCountByStatus('open', $tag, $issue_ids);␊
         $closed = $prj->getIssueCountByStatus('closed', $tag, $issue_ids);␊
 ␊
         // Get stats about the open/closed issues having this tag.␊
         $open = $prj->getIssueCountByStatus('open', $tag);␊
         $closed = $prj->getIssueCountByStatus('closed', $tag);␊
-        $overdue = $prj->getIssueCountByDueDate('overdue', 'open', $tag);␊
+        $overdue = $prj->getIssueCountByDueDate('overdue', $tag);␊
         // Paginator to paginate the issues␊
         $pag = new Pluf_Paginator(new IDF_Issue());␊
         $pag->model_view = 'join_tags';␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags