Indefero Commit Details

Date:

2008-08-05 12:58:21 (17 years 4 months ago)

Author:

Loic d'Anterroches

Branch:

dev, develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3, svn

Commit:

3990098e4b124ae065cb819dd633551fea56f8ea

Parents:

5e3b2bac28da61363c59f2bddde2210645064183

Message:

Added better control that the issue/download are in the project.

When you view/edit a download or issue, if the download/issue is not in
the current project a 404 page is returned.

Changes:

File differences

-319
320 320
321 321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
322 338
+        // containing a series of git repositories␊
        return $gitrep.'/'.$this->shortname.'.git';␊
    }␊
␊
    /**␊
     * Check that the object belongs to the project or rise a 404␊
     * error.␊
     *␊
     * By convention, all the objects belonging to a project have the␊
     * 'project' property set, so this is easy to check.␊
     *␊
     * @param Pluf_Model ␊
     */␊
    public function inOr404($obj)␊
    {␊
        if ($obj->project != $this->id) {␊
            throw new Pluf_HTTP_Error404();␊
        }␊
    }␊
}
         // containing a series of git repositories␊
         return $gitrep.'/'.$this->shortname.'.git';␊
     }␊
+␊
+    /**␊
+     * Check that the object belongs to the project or rise a 404␊
+     * error.␊
+     *␊
+     * By convention, all the objects belonging to a project have the␊
+     * 'project' property set, so this is easy to check.␊
+     *␊
+     * @param Pluf_Model ␊
+     */␊
+    public function inOr404($obj)␊
+    {␊
+        if ($obj->project != $this->id) {␊
+            throw new Pluf_HTTP_Error404();␊
+        }␊
+    }␊
 }

-161
162 162
163 163
164 
165 
166 
164
167 165
168 166
169 167
+    {␊
        $prj = $request->project;␊
        $issue = Pluf_Shortcuts_GetObjectOr404('IDF_Issue', $match[2]);␊
        if ($issue->project != $prj->id) {␊
            throw new Pluf_HTTP_Error404();␊
        }␊
        $prj->inOr404($issue);␊
        $comments = $issue->get_comments_list(array('order' => 'id ASC'));␊
        $url = Pluf_HTTP_URL_urlForView('IDF_Views_Issue::view',␊
                                        array($prj->shortname, $issue->id));␊
     {␊
         $prj = $request->project;␊
         $issue = Pluf_Shortcuts_GetObjectOr404('IDF_Issue', $match[2]);␊
-        if ($issue->project != $prj->id) {␊
-            throw new Pluf_HTTP_Error404();␊
-        }␊
+        $prj->inOr404($issue);␊
         $comments = $issue->get_comments_list(array('order' => 'id ASC'));␊
         $url = Pluf_HTTP_URL_urlForView('IDF_Views_Issue::view',␊
                                         array($prj->shortname, $issue->id));␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags