Indefero Commit Details

Date:

2011-04-01 04:15:13 (14 years 1 month ago)

Author:

Thomas Keller

Branch:

develop, feature-issue_links, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, release-1.1, release-1.2, release-1.3

Commit:

346b2c6cf8dc944417021ba5c6580a56fe2f698f

Parents:

67d8936083db102fa929a4687a06fde27da5f3b4

Message:

Call validateRevision(), not isValidRevision(), fixes issue 657

Changes:

File differences

-94
95 95
96 96
97 
97
98 98
99 99
100 100
... ...
336 336
337 337
338 338
339 
339
340 340
341 341
342 342
+                       escapeshellarg($this->repo),␊
                       escapeshellarg($rev));␊
        $cmd = Pluf::f('idf_exec_cmd_prefix', '').$cmd;␊
        self::exec('IDF_Scm_Mercurial::isValidRevision', $cmd, $out, $ret);␊
        self::exec('IDF_Scm_Mercurial::validateRevision', $cmd, $out, $ret);␊
␊
        // FIXME: apparently a given hg revision can also be ambigious -␊
        //        handle this case here sometime␊

     */␊
    public function getCommit($commit, $getdiff=false)␊
    {␊
        if (!$this->isValidRevision($commit)) {␊
        if ($this->validateRevision($commit) != IDF_Scm::REVISION_VALID) {␊
            return false;␊
        }␊
        $tmpl = ($getdiff)␊
 ...
                        escapeshellarg($this->repo),␊
                        escapeshellarg($rev));␊
         $cmd = Pluf::f('idf_exec_cmd_prefix', '').$cmd;␊
-        self::exec('IDF_Scm_Mercurial::isValidRevision', $cmd, $out, $ret);␊
+        self::exec('IDF_Scm_Mercurial::validateRevision', $cmd, $out, $ret);␊
 ␊
         // FIXME: apparently a given hg revision can also be ambigious -␊
         //        handle this case here sometime␊
      */␊
     public function getCommit($commit, $getdiff=false)␊
     {␊
-        if (!$this->isValidRevision($commit)) {␊
+        if ($this->validateRevision($commit) != IDF_Scm::REVISION_VALID) {␊
             return false;␊
         }␊
         $tmpl = ($getdiff)␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags