Indefero Commit Details

Date:

2008-08-29 12:59:53 (17 years 2 months ago)

Author:

Loic d'Anterroches

Branch:

dev, develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3, svn

Commit:

2c7b3e1e1a08849d276698dd6d9ef903df90f12f

Parents:

ccc41c86b0677ff1d6d79ec1755c34a8ac5e2cab

Message:

Cosmetic improvements.

Changes:

File differences

-35
36 36
37 37
38 
39 
40 
41 
42 
43 
44 
45 
46 
38
39
47 40
48 41
49 42
50 
43
44
45
51 46
52 47
53 48
+    public static function getScm($request=null)␊
    {␊
        // Get scm type from project conf ; defaults to git␊
        $scm = $request->conf->getVal('scm', 'git');␊
␊
        // CASE: git␊
        if ($scm === 'git') {␊
            return new IDF_Git($request->project->getGitRepository());␊
        }␊
␊
        // CASE: svn␊
        if ($scm === 'svn') {␊
        switch ($request->conf->getVal('scm', 'git')) {␊
        case 'svn':␊
            return new IDF_Svn($request->conf->getVal('svn_repository'),␊
                               $request->conf->getVal('svn_username'),␊
                               $request->conf->getVal('svn_password'));␊
        }␊
        case 'git':␊
        default:␊
            return new IDF_Git($request->project->getGitRepository());␊
    }␊
}␊
␊
     public static function getScm($request=null)␊
     {␊
         // Get scm type from project conf ; defaults to git␊
-        $scm = $request->conf->getVal('scm', 'git');␊
-␊
-        // CASE: git␊
-        if ($scm === 'git') {␊
-            return new IDF_Git($request->project->getGitRepository());␊
-        }␊
-␊
-        // CASE: svn␊
-        if ($scm === 'svn') {␊
+        switch ($request->conf->getVal('scm', 'git')) {␊
+        case 'svn':␊
             return new IDF_Svn($request->conf->getVal('svn_repository'),␊
                                $request->conf->getVal('svn_username'),␊
                                $request->conf->getVal('svn_password'));␊
-        }␊
+        case 'git':␊
+        default:␊
+            return new IDF_Git($request->project->getGitRepository());␊
     }␊
 }␊
 ␊

-334
335 335
336 336
337 
337
338
338 339
339 340
340 341
+     */␊
    private function getScmType($request)␊
    {␊
        return ucfirst($scm = $request->conf->getVal('scm', 'git'));␊
        return mb_convert_case($request->conf->getVal('scm', 'git'),␊
                               MB_CASE_TITLE, 'UTF-8');␊
    }␊
}␊
␊
      */␊
     private function getScmType($request)␊
     {␊
-        return ucfirst($scm = $request->conf->getVal('scm', 'git'));␊
+        return mb_convert_case($request->conf->getVal('scm', 'git'),␊
+                               MB_CASE_TITLE, 'UTF-8');␊
     }␊
 }␊
 ␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags