Indefero Commit Details

Date:

2010-09-15 03:46:10 (14 years 7 months ago)

Author:

Thomas Keller

Branch:

develop, feature-issue_links, feature.better-home, feature.content-md5, feature.diff-whitespace, feature.download-md5, feature.issue-links, feature.issue-of-others, feature.issue-summary, feature.search-filter, feature.webrepos, feature.wiki-default-page, master, release-1.1, release-1.2, release-1.3

Commit:

29b8bf8a4e692f8407beb57aff81fd64a9d33459

Parents:

42936cc51d9b222cb8b0fbc03775ce5b652381aa

Message:

Some revisions might not carry a branch cert (yet), because they're part of another branch whose certs haven't been pushed into the server yet, so we need to skip these revisions while going back in time for the changelog. The initial revision however must carry a branch cert, otherwise we have nothing to "follow".

Changes:

File differences

-680
681 681
682 682
683
684
685
686
687
688
683 689
684 690
685 691
686 692
687 
693
694
688 695
689 696
690 697
+␊
            // read in the initial branches we should follow␊
            if (count($initialBranches) == 0) {␊
                if (!isset($certs['branch'])) {␊
                    throw new IDF_Scm_Exception(sprintf(␊
                        __("revision %s has no branch cert - cannot start ".␊
                           "logging from this revision"), $rev␊
                    ));␊
                } ␊
                $initialBranches = $certs['branch'];␊
            }␊
␊
            // only add it to our log if it is on one of the initial branches␊
            if (count(array_intersect($initialBranches, $certs['branch'])) > 0) {␊
            // ignore revisions without any branch certificate␊
            if (count(array_intersect($initialBranches, (array)@$certs['branch'])) > 0) {␊
                --$n;␊
␊
                $log = array();␊
 ␊
             // read in the initial branches we should follow␊
             if (count($initialBranches) == 0) {␊
+                if (!isset($certs['branch'])) {␊
+                    throw new IDF_Scm_Exception(sprintf(␊
+                        __("revision %s has no branch cert - cannot start ".␊
+                           "logging from this revision"), $rev␊
+                    ));␊
+                } ␊
                 $initialBranches = $certs['branch'];␊
             }␊
 ␊
             // only add it to our log if it is on one of the initial branches␊
-            if (count(array_intersect($initialBranches, $certs['branch'])) > 0) {␊
+            // ignore revisions without any branch certificate␊
+            if (count(array_intersect($initialBranches, (array)@$certs['branch'])) > 0) {␊
                 --$n;␊
 ␊
                 $log = array();␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags