Indefero Commit Details

Date:

2012-04-27 08:57:18 (12 years 7 months ago)

Author:

Simon Holywell

Branch:

develop

Commit:

158f9288d30a11253e3b82080494d904ae3e8b1f

Parents:

e883f22790a2c1b95beb88c21e8db64861bce9c3

Message:

Try to avoid anchors with '#' as target and use 'javascript:void(0);' instead

Changes:

File differences

-73
74 74
75 75
76 
76
77 77
78 78
79 79
... ...
140 140
141 141
142 142
143 
144 143
145 144
146 145
+        {foreach $date_shortcuts as $time_span => $shortcuts}␊
            <dt>{$time_span}</dt>␊
            {foreach $shortcuts as $title => $date}␊
                <dd><a href="#" rel="{$date}" class="due_dtime_shortcut">{$title}</a></dd>␊
                <dd><a href="javascript:void(0);" rel="{$date}" class="due_dtime_shortcut">{$title}</a></dd>␊
            {/foreach}␊
        {/foreach}␊
    </dl>␊

    });␊
    $(".due_dtime_shortcut").click(function(){␊
        $('#id_due_dtime').val($(this).attr('rel'));␊
        return false;␊
    });␊
    // Hide the upload forms, we insert before the first attach file␊
    // row an "Attach File" little link.␊
 ...
         {foreach $date_shortcuts as $time_span => $shortcuts}␊
             <dt>{$time_span}</dt>␊
             {foreach $shortcuts as $title => $date}␊
-                <dd><a href="#" rel="{$date}" class="due_dtime_shortcut">{$title}</a></dd>␊
+                <dd><a href="javascript:void(0);" rel="{$date}" class="due_dtime_shortcut">{$title}</a></dd>␊
             {/foreach}␊
         {/foreach}␊
     </dl>␊
     });␊
     $(".due_dtime_shortcut").click(function(){␊
         $('#id_due_dtime').val($(this).attr('rel'));␊
-        return false;␊
     });␊
     // Hide the upload forms, we insert before the first attach file␊
     // row an "Attach File" little link.␊

-138
139 139
140 140
141 
141
142 142
143 143
144 144
... ...
244 244
245 245
246 246
247 
248 247
249 248
250 249
+        {foreach $date_shortcuts as $time_span => $shortcuts}␊
            <dt>{$time_span}</dt>␊
            {foreach $shortcuts as $title => $date}␊
                <dd><a href="#" rel="{$date}" class="due_dtime_shortcut">{$title}</a></dd>␊
                <dd><a href="javascript:void(0);" rel="{$date}" class="due_dtime_shortcut">{$title}</a></dd>␊
            {/foreach}␊
        {/foreach}␊
    </dl>␊

    });␊
    $(".due_dtime_shortcut").click(function(){␊
        $('#id_due_dtime').val($(this).attr('rel'));␊
        return false;␊
    });␊
    // Hide the upload forms, we insert before the first attach file␊
    // row an "Attach File" little link.␊
 ...
         {foreach $date_shortcuts as $time_span => $shortcuts}␊
             <dt>{$time_span}</dt>␊
             {foreach $shortcuts as $title => $date}␊
-                <dd><a href="#" rel="{$date}" class="due_dtime_shortcut">{$title}</a></dd>␊
+                <dd><a href="javascript:void(0);" rel="{$date}" class="due_dtime_shortcut">{$title}</a></dd>␊
             {/foreach}␊
         {/foreach}␊
     </dl>␊
     });␊
     $(".due_dtime_shortcut").click(function(){␊
         $('#id_due_dtime').val($(this).attr('rel'));␊
-        return false;␊
     });␊
     // Hide the upload forms, we insert before the first attach file␊
     // row an "Attach File" little link.␊

Download the corresponding diff file

Indefero

File differences

Branches

Tags