srchub Commit Details

Date:

2016-05-01 15:44:43 (9 years 6 months ago)

Author:

Natalie Adams

Branch:

master

Commit:

5d37f6fa6c3a11397277cdf36ccac99184ddb1d3

Parents:

cc88235d78df053119ca16b4c90ac440df5f2e10

Message:

Issue 157: Force download of preview if file is large

Changes:

File differences

-211
212 212
213 213
214 
214
215
216
215 217
216 218
217 219
+        if ($request_file_info->type != 'tree') {␊
            $info = self::getRequestedFileMimeType($request_file_info,␊
                                                   $commit, $scm);␊
            if (!IDF_FileUtil::isText($info) && !IDF_FileUtil::isImage($info)) {␊
            $previewSizeLimit = Pluf::f("preview_size_limit", 2000000);␊
            if (!IDF_FileUtil::isText($info) && !IDF_FileUtil::isImage($info) ||␊
                (!IDF_FileUtil::isImage($info) && $request_file_info->size >= $previewSizeLimit)) {␊
                $rep = new Pluf_HTTP_Response($scm->getFile($request_file_info),␊
                                              $info[0]);␊
                $rep->headers['Content-Disposition'] = 'attachment; filename="'.$info[1].'"';␊
         if ($request_file_info->type != 'tree') {␊
             $info = self::getRequestedFileMimeType($request_file_info,␊
                                                    $commit, $scm);␊
-            if (!IDF_FileUtil::isText($info) && !IDF_FileUtil::isImage($info)) {␊
+            $previewSizeLimit = Pluf::f("preview_size_limit", 2000000);␊
+            if (!IDF_FileUtil::isText($info) && !IDF_FileUtil::isImage($info) ||␊
+                (!IDF_FileUtil::isImage($info) && $request_file_info->size >= $previewSizeLimit)) {␊
                 $rep = new Pluf_HTTP_Response($scm->getFile($request_file_info),␊
                                               $info[0]);␊
                 $rep->headers['Content-Disposition'] = 'attachment; filename="'.$info[1].'"';␊

Download the corresponding diff file

srchub

File differences

Branches