srchub Commit Details

Date:

2015-09-03 20:40:47 (10 years 1 month ago)

Author:

Natalie Adams

Branch:

master

Commit:

1c563f340b393347ede2e5ac917499ae1d946112

Parents:

90ce6fda4cea41943f75e7e0e6794f28fbaf0b49

Message:

Issue 102: Potential race condition when compiling templates

Changes:

File differences

-144
145 145
146 146
147 
147
148
148 149
149 150
151
150 152
151 153
152 154
+            rewind($fp); ␊
            fwrite($fp, $this->template_content, strlen($this->template_content));␊
            // Lock released, read access is possible␊
            flock($fp, LOCK_UN);  ␊
            flock($fp, LOCK_UN);␊
            fflush($fp);␊
            fclose($fp);␊
            @chmod($this->compiled_template, 0777);␊
            clearstatcache();␊
            return true;␊
        } else {␊
            throw new Exception(sprintf(__('Cannot write the compiled template: %s'), $this->compiled_template));␊
             rewind($fp); ␊
             fwrite($fp, $this->template_content, strlen($this->template_content));␊
             // Lock released, read access is possible␊
-            flock($fp, LOCK_UN);  ␊
+            flock($fp, LOCK_UN);␊
+            fflush($fp);␊
             fclose($fp);␊
             @chmod($this->compiled_template, 0777);␊
+            clearstatcache();␊
             return true;␊
         } else {␊
             throw new Exception(sprintf(__('Cannot write the compiled template: %s'), $this->compiled_template));␊