srchub

Issue 112: Missing git information for some files


Reported by Natalie Adams, Nov, 15 2015 10:31:39 PM

When viewing the source via the web interface there appears to be 
missing information for a file (such as date committed, and log)

Comment 1 by Natalie Adams, Nov, 15 2015 10:38:25 PM

This was an interesting bug.

It dealt with the fact that the system caches commit data. The 
commit data includes the hash of the file. If there were 2 or more 
files with the same hash (ie same contents) - the system would 
override array keys causing loss of data. When indefero went to 
display the information - it only had the default information (which 
was to display nothing).

After some debugging I decided a better approach was to do the 
following:

    SHA1(SHA1(file hash) + full path of file)

The SHA1 file hash was provided by git. Combining the file hash + 
full path should result in a unique hash.

This bug may appear in other SCM backends - so I'll create tickets 
to verify those.

Comment 2 by Natalie Adams, Nov, 15 2015 10:41:54 PM

Status: Fixed

Comment 3 by Natalie Adams, Nov, 15 2015 10:51:49 PM

Status: Started

Comment 4 by Natalie Adams, Nov, 16 2015 11:08:07 PM

A temporary fix has been put into place for the git SCM.

The fix will cache ALL data for all commits on source view - rather 
than just the commit it needs. I need to write it so that it only 
cares about the commit the user is currently looking at.

Comment 5 by Natalie Adams, Nov, 16 2015 11:12:32 PM

Status: TemporaryFix

Comment 6 by Natalie Adams, Apr, 23 2016 12:02:13 PM

Ok this should be finally fixed properly in 
3f699e0afddab7f35cf88b8be446cddbeaa0c013

Comment 7 by Natalie Adams, Apr, 23 2016 12:29:53 PM

Status: Fixed

Created: 9 years 4 months ago by Natalie Adams

Updated: 8 years 10 months ago

Status: Fixed

Owner: Natalie Adams

Labels:
Type:Defect
Priority:Medium

This issue is related to
113 - Check hg backend
114 - Check SVN backend

Page rendered in 0.10859s using 58 queries.