pluf2 Commit Details

Date:

2010-04-28 03:13:04 (15 years 6 months ago)

Author:

Mehdi Kabab

Branch:

master

Commit:

4753b98fde22fa9681c27152d99d0c196ea5a45b

Parents:

55a13cb2fd3f2dd8be9421ad0df675ac60db7765

Message:

Simpler code for Pluf_HTTP_URL::generate()

Changes:

File differences

-43
44 44
45 45
46 
47 
48 
49 
50 
51 46
52 
53 
54 
55 
56 
57 
58 
47
48
59 49
60 50
61 51
+     */␊
    public static function generate($action, $params=array(), $encode=true)␊
    {␊
        if ($encode) {␊
            $amp = '&amp;';␊
        } else {␊
            $amp = '&';␊
        }␊
        $url = $action;␊
        if (count($params) > 0) {␊
            $url .= '?';␊
            $params_list = array();␊
            foreach ($params as $key=>$value) {␊
                $params_list[] = urlencode($key).'='.urlencode($value);␊
            }␊
            $url .= implode($amp, $params_list);␊
        if (count($params)) {␊
            $url .= '?' . http_build_query($params, '', ($encode) ? '&amp;' : '&');␊
        }␊
        return $url;␊
    }␊
      */␊
     public static function generate($action, $params=array(), $encode=true)␊
     {␊
-        if ($encode) {␊
-            $amp = '&amp;';␊
-        } else {␊
-            $amp = '&';␊
-        }␊
         $url = $action;␊
-        if (count($params) > 0) {␊
-            $url .= '?';␊
-            $params_list = array();␊
-            foreach ($params as $key=>$value) {␊
-                $params_list[] = urlencode($key).'='.urlencode($value);␊
-            }␊
-            $url .= implode($amp, $params_list);␊
+        if (count($params)) {␊
+            $url .= '?' . http_build_query($params, '', ($encode) ? '&amp;' : '&');␊
         }␊
         return $url;␊
     }␊

Download the corresponding diff file

pluf2

File differences

Branches