pluf2 Commit Details

Date:

2010-04-10 11:27:56 (14 years 8 months ago)

Author:

Loic d'Anterroches

Branch:

master

Commit:

2f8fb90ebd6d024ad9ebb7d471ffdfddd4f750e2

Parents:

6babdf56bea2463f6e2e347ab8cd26654fdb25c4

Message:

Fixed a corner case when no stats are available.

Changes:

File differences

-148
149 149
150 150
151 
152 
153 
154 
151
152
153
154
155
156
157
155 158
156 159
157 160
+        }␊
        $t1 = $steps[1]['total'];␊
        $tprops = array();␊
        foreach ($steps[1]['props'] as $v => $t) {␊
            $tprops[$v] = $t; // some properties are set only in the␊
                              // middle of the funnel, we get the␊
                              // value in the step.␊
        if (isset($steps[1]['props'])) {␊
            foreach ($steps[1]['props'] as $v => $t) {␊
                $tprops[$v] = $t; ␊
                // some properties are set only in the␊
                // middle of the funnel, we get the␊
                // value in the step.␊
            }␊
        }␊
        for ($i=2;$i<=20;$i++) {␊
            if ($steps[$i] and $steps[$i-1]) {␊
         }␊
         $t1 = $steps[1]['total'];␊
         $tprops = array();␊
-        foreach ($steps[1]['props'] as $v => $t) {␊
-            $tprops[$v] = $t; // some properties are set only in the␊
-                              // middle of the funnel, we get the␊
-                              // value in the step.␊
+        if (isset($steps[1]['props'])) {␊
+            foreach ($steps[1]['props'] as $v => $t) {␊
+                $tprops[$v] = $t; ␊
+                // some properties are set only in the␊
+                // middle of the funnel, we get the␊
+                // value in the step.␊
+            }␊
         }␊
         for ($i=2;$i<=20;$i++) {␊
             if ($steps[$i] and $steps[$i-1]) {␊

-70
71 71
72 72
73 
73
74 74
75 75
76 76
77 77
78 78
79 79
80 
80
81 81
82 82
83 
84 
83
84
85 85
86 86
87 87
+{assign $i = $i-1}␊
<p><strong>{$stats[$i]['total']}</strong> out of {$stats['1']['total']} visitors reached step {$i} of this funnel.␊
This is a completion rate of <strong>{$stats[$i]['conv1']}</strong>.</p>␊
␊
{if count($props) and isset($stats[$i]['sprops1'])}␊
<div class="propsstats">{assign $stepprops = $stats[$i]['sprops1']}␊
<h2>Visitor Property {$prop} </h2>␊
{foreach $stepprops as $k=>$t}␊
<p><strong>{$k}</strong>: {assign $nn = $t[1]}␊
{$t[0]} out of {blocktrans $nn}{$nn} visitor{plural}{$nn} visitors{/blocktrans}{if $t[2]} ({$t[2]}){/if}␊
{/foreach}</p>␊
</div>␊
</div>{/if}␊
<p class="note">␊
Note that if a user skip a given step, this can make the results a bit␊
off. For the overall property funnel statistics, the first step where a given ␊
appears is used as the base value.␊
off.{if count($props)} For the overall property funnel statistics, the first step where a given ␊
appears is used as the base value.{/if}␊
</p>␊
{else}␊
<p>We do not have statistics for this period.</p>␊
 {assign $i = $i-1}␊
 <p><strong>{$stats[$i]['total']}</strong> out of {$stats['1']['total']} visitors reached step {$i} of this funnel.␊
 This is a completion rate of <strong>{$stats[$i]['conv1']}</strong>.</p>␊
-␊
+{if count($props) and isset($stats[$i]['sprops1'])}␊
 <div class="propsstats">{assign $stepprops = $stats[$i]['sprops1']}␊
 <h2>Visitor Property {$prop} </h2>␊
 {foreach $stepprops as $k=>$t}␊
 <p><strong>{$k}</strong>: {assign $nn = $t[1]}␊
 {$t[0]} out of {blocktrans $nn}{$nn} visitor{plural}{$nn} visitors{/blocktrans}{if $t[2]} ({$t[2]}){/if}␊
 {/foreach}</p>␊
-</div>␊
+</div>{/if}␊
 <p class="note">␊
 Note that if a user skip a given step, this can make the results a bit␊
-off. For the overall property funnel statistics, the first step where a given ␊
-appears is used as the base value.␊
+off.{if count($props)} For the overall property funnel statistics, the first step where a given ␊
+appears is used as the base value.{/if}␊
 </p>␊
 {else}␊
 <p>We do not have statistics for this period.</p>␊

Download the corresponding diff file

pluf2

File differences

Branches