Pluf Framework Commit Details

Date:

2008-11-21 06:57:30 (16 years 5 months ago)

Author:

Loic d'Anterroches

Branch:

develop, master

Commit:

161080f312c4eb24c6d508adfcebdc6745e29428

Parents:

1aa66025b77aeb5a17860888652762b368e14fee

Message:

Fixed issue with the checkbox not correctly unchecked.

Changes:

File differences

-43
44 44
45 45
46 
47 
48 
49 
46
47
48
50 49
51 50
52 51
... ...
58 57
59 58
60 59
61 
62 
60
61
63 62
64 63
65 64
+            // true, then we check the box.␊
            $extra_attrs['checked'] = 'checked';␊
        }␊
        // We force the value to '', the "real" value is passed␊
        // through the extra_attrs. This is because a checkbox can␊
        // have a value and also the checked/unchecked state.␊
        return parent::render($name, '', $extra_attrs);␊
        // Value of a checkbox is always "1" but when not checked, the␊
        // corresponding key in the form associative array is not set.␊
        return parent::render($name, '1', $extra_attrs);␊
    }␊
␊
    /**␊

     */␊
    public function valueFromFormData($name, $data)␊
    {␊
        if (!isset($data[$name]) ␊
            or false === $data[$name] or (string)$data[$name] === '0') {␊
        if (!isset($data[$name]) or false === $data[$name] ␊
            or (string)$data[$name] === '0' or $data[$name] == '') {␊
            return false;␊
        }␊
        return true;␊
 ...
             // true, then we check the box.␊
             $extra_attrs['checked'] = 'checked';␊
         }␊
-        // We force the value to '', the "real" value is passed␊
-        // through the extra_attrs. This is because a checkbox can␊
-        // have a value and also the checked/unchecked state.␊
-        return parent::render($name, '', $extra_attrs);␊
+        // Value of a checkbox is always "1" but when not checked, the␊
+        // corresponding key in the form associative array is not set.␊
+        return parent::render($name, '1', $extra_attrs);␊
     }␊
 ␊
     /**␊
      */␊
     public function valueFromFormData($name, $data)␊
     {␊
-        if (!isset($data[$name]) ␊
-            or false === $data[$name] or (string)$data[$name] === '0') {␊
+        if (!isset($data[$name]) or false === $data[$name] ␊
+            or (string)$data[$name] === '0' or $data[$name] == '') {␊
             return false;␊
         }␊
         return true;␊

Download the corresponding diff file

Pluf Framework

File differences

Branches

Tags